search

atulmish / UnitConversion

Expansible Unit Conversion Library for .Net Core and .Net Framework
MIT License
181 stars 28 forks source link

Converting between units which do not (or not only) have just a factor #15

Open rohitjha opened 7 years ago

rohitjha commented 7 years ago

Currently we only support conversion between units of the form: left = right * factor. However, for temperature conversion, the units such as Celsius, Fahrenheit and Kelvin are not convertible by multiplication with factors.

gkampolis commented 6 years ago

Noted. 👍

I'm planning of incorporating a Temperature "module" later on, after I'm done with setting the codebase along with standards implemented in stylecop. Of course, you're more than welcome to give it a try after I set up the codebase. :)

rohitjha commented 6 years ago

Sounds good, I'll give it a shot then. :+1:

gkampolis commented 6 years ago

@rohitjha Just make sure you 're-fork' the repo so you'll have the latest changes to the codebase, otherwise it won't be easy to merge your pull request. :)

rohitjha commented 6 years ago

:+1:

MarkusKgit commented 6 years ago

I had my own go with a more generic conversion function to support temperature conversions and more. Unfortunately it would be a breaking change to the existing code base. Check out my fork to see it.