search

atuttle / Taffy

:candy: The REST Web Service framework for ColdFusion and Lucee
http://taffy.io
Other
226 stars 118 forks source link

Fixed some java version issues on my CF8 #359

Closed cfmitrah closed 5 years ago

cfmitrah commented 6 years ago
atuttle commented 6 years ago

Why are you on such an old JVM version? The number of security fixes for it alone should be enough to get approval to upgrade, right?

I don't know what to think about this change. I believe @ryanguill wrote the code so I'll ask him to take a look at it.

mcbitss commented 6 years ago

@atuttle client is using it in corporate environment, lot of procedure & approval needs to happened to upgrade JAVA version. you knew how old corporate office's in process :)

ryanguill commented 6 years ago

I don't remember writing that code, but I can imagine I did :)

What StringBuffer operations are not possible in 1.6.0_01 @cfmitrah? All I see us using is the constructor, setLength and append(string) all of which seem to be supported looking at the docs.

It could be switched to an array though and then use arrayToList() to convert it back to the string, in lots of environments - even modern ones - that can actually be faster nowadays. Changing it to just be a string though would probably be a step back in performance for all platforms.

But seriously, 1.6 with the latest patch is still horribly out of date and out of support - trying to support 1.6.0_01 isn't something I would recommend for the project. Not to mention the fact that CF8 itself isnt supported.

pfreitag commented 5 years ago

I'd suggest closing this PR as Java 1.6 is even more out of date now. If anyone really needs 1.6 support they can always find this PR and patch their own implementation. @atuttle are you ok with closing it?