atuttle / atom-language-cfml

:space_invader: A CFML Language for the Atom Editor
38 stars 24 forks source link

Code completion generates <<cfsometag ... #46

Closed Ratcreamsoup closed 7 years ago

Ratcreamsoup commented 9 years ago

When using code completion for a tag snippet by typing <cfsometag, the snippet inserts a superflous bracket character < before the tag. So either one has to get used to leaving off the leading bracket when typing the beginning of the tag or you'd have to jump back to the start of the tag in order to delete the superflous bracket.

If I type <cfso and use code completion for <cfsometag, I'd expect the snippet it to complete this to exactly this <cfsometag, not to <<cfsometag.

Is there some setting that I may have missed that would rectify this?

Anyway, thank you very much indeed for this great atom package, we're finally able to ditch Dreamweaver for development!

tollus commented 9 years ago

When you use the code completion you don't want to write the original <. For example, you just want to write cfset then choose the snippet, and you'll see it changes the cfset to <cfset | = > (where | is where the cursor is)

philcruz commented 9 years ago

Typing the opening bracket is a common way to start code completion, well, at least with CFEclipse. So it will be a smoother transition for such folks. +1 for Atom supporting this.

rwatts3 commented 9 years ago

This package could check if the first character is < then replace it when the snippet is embedded.

andrew-dixon commented 8 years ago

I think it actually needs the package upgraded to use Atom's autocomplete-plus as ATM it is just inserting snippets and not auto-completing as such.

KrunchMuffin commented 8 years ago

I agree with @andrew-dixon plus it's a PITA removing superfluous code that gets inserted. I am still using sublime 3 because of this. Would love to switch to Atom.

zoo1 commented 7 years ago

I resolved this issue in my CFML autocomplete package, you can find it here

dnando commented 7 years ago

Couldn't find auto-complete plus in the Atom package search, but then looking at the github repository I saw that you don't have to install it - included with Atom.

I just installed CFML autocomplete, tried it and still seeing

<<cfset = >

:-(

Aria Media Sagl +41 (0)76 303 4477 cell skype: ariamedia

On Fri, Nov 11, 2016 at 8:10 PM, Zachary Ovington notifications@github.com wrote:

I resolved this issue in my CFML autocomplete package, you can find it here https://atom.io/packages/autocomplete-cfml

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/atuttle/atom-language-cfml/issues/46#issuecomment-260031846, or mute the thread https://github.com/notifications/unsubscribe-auth/AAh2n4cgJZAEUjO0oN8yEM5yRoaxeeftks5q9L2LgaJpZM4FdXWj .

zoo1 commented 7 years ago

@dnando make sure you are selecting that auto-complete tag part of autocomplete CFML to insert and not the snippets included in this package. The autocomplete included should look like the image below. The red elements are autocomplete added. cfset

zoo1 commented 7 years ago

@dnando sorry for the confusion, I just published a fix for this. If you have any other issues feel free to open them on the autocomplete repo. I'm closing this ticket as this functionality will not be added by this language package.

dnando commented 7 years ago

Ah, I see what's happening.

If I type <cf and then choose from the dropdown, remaining within the choices that have red brackets, it works.

[image: Inline image 2]

If I type <cfs, it jumps down into the green tab choices and then what is inserted is a double bracket to start, as below:

[image: Inline image 1]

The behavior is different if one remembers to not type the initial opening bracket. Then it works as you've shown in your screenshot.

The << issue occurs if the opening bracket is typed.

Thanks for doing this. I like it.

Aria Media Sagl +41 (0)76 303 4477 cell skype: ariamedia

On Fri, Nov 11, 2016 at 8:57 PM, Zachary Ovington notifications@github.com wrote:

@dnando https://github.com/dnando make sure you are selecting that auto-complete tag part of autocomplete CFML to insert and not the snippets included in this package. The autocomplete included should look like the image below. The red elements are autocomplete added. [image: cfset] https://cloud.githubusercontent.com/assets/4008169/20228438/1ed9538c-a81f-11e6-89a1-79fd90fd9fc9.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/atuttle/atom-language-cfml/issues/46#issuecomment-260042269, or mute the thread https://github.com/notifications/unsubscribe-auth/AAh2nxB0OtgAg1Xl5M0slXvNwsqbExXWks5q9MjFgaJpZM4FdXWj .

zoo1 commented 7 years ago

@dnando <cfs should work in the version I just pushed out.