atuttle / atom-language-cfml

:space_invader: A CFML Language for the Atom Editor
38 stars 24 forks source link

Syntax highlighting breaks for cfcomponent tags with the word ' interface' in an attribute string #65

Closed sheenjustin closed 8 years ago

sheenjustin commented 9 years ago

Breaking: cfcomponentsyntaxfailing

Non-breaking: cfcomponentsyntaxpassing

Edit: The word ' interface' doesn't even have to be in an attribute string. Breaking: alsofailing

Non-breaking: alsopassing2

Also Non-breaking: alsopassing

elpete commented 9 years ago

Hi, @sheenjustin. A few clarifying questions for you:

What version of Atom are you running? (Find your version in Menu -> Atom -> About Atom) (Current version is 1.2.4) What syntax is currently being used? (Bottom right corner. Something like cfml.) What version of atom-language-cfml are you using? (Current version is 0.10.0)

Thanks!

sheenjustin commented 9 years ago

He @elpete, I was running 1.0.19 but the problem persisted after upgrading to 1.2.4. I'm also on the latest version of atom-language-cfml, 0.10.0.

The syntax that is used is cfscript, and I'm unable to change out of that syntax to either cfml or html(cfml). After a cursory glance at the grammar files, I think the problem is coming from cfscript.cson, line 26. It's doing a match for interface and assigns the tag to the script syntax. At least, that's what my understanding of the code is. I'm not super familiar with cson.

elpete commented 9 years ago

Using tags like you are, cfscript is not the right grammar. If you click on the grammar name in the bottom right corner you should be able to search for CFML (not HTML (CFML)).

Can you try that and let us know if that fixes your issue?

elpete commented 9 years ago

@sheenjustin Did you have a chance to use the cfml grammar for this? Did that fix your issue?

elpete commented 8 years ago

Closing this issue as we couldn't reproduce it.