search

atwellpub / resend-welcome-email

WordPress plugin that helps quickly regenerate a new passwords & send a new welcome email to a user.
17 stars 15 forks source link

Add fr_FR translation #17

Closed tbnv closed 6 years ago

tbnv commented 6 years ago

@atwellpub Thanks for the merge.

It's weird though, the translation is not applied. I see this in Loco Translate:

Additional files found This bundle isn't fully configured, so we don't know what the following files are for.

And this

This bundle's configuration has been automatically detected, but isn't fully complete. 4 files can't be matched to a known set of strings

atwellpub commented 6 years ago

Good eye. Looks like because the plugin is loaded in init the text domain isn't loaded. I tried to change the hook level to be loaded before init but it broke the email send routine. I pulled the text-domain loader method outside of the plugin's main class and it's working now.

Fixed in 1.1.8

atwellpub commented 6 years ago

If you want to add your WordPress.org username to the readme.txt's contributor list, I'll accept the pull request. It may be fun to have it there.

Also there's a spot for translators in the readme.md file.

tbnv commented 6 years ago

I added myself to the readme, thanks!