atwwei / ngx-dfp

Semantic DoubleClick for Publishers (DFP by Google) integration with Angular v6.0.
16 stars 15 forks source link

Add in directive value for personalizedAds in specific case #24

Closed DanielGBullido closed 6 years ago

DanielGBullido commented 6 years ago

In order to control ads 100%, I thought it would be great to add this option as a policy variable because in the configuration it falls short, imagine that in some case you have to modify that true to false for some user configuration ... I can not update the definition of the module, so having it in the directive I think it would help to solve these cases.

thanks

atwwei commented 6 years ago

No actual effect, no need to do so.

Thanks anyway

atwwei commented 6 years ago

Useless code!

Please read the related documents and test the modified code carefully .

Thanks anyway