search

atwwei / ngx-dfp

Semantic DoubleClick for Publishers (DFP by Google) integration with Angular v6.0.
16 stars 15 forks source link

`setForceSafeFrame` is always called #25

Closed wmaurer closed 6 years ago

wmaurer commented 6 years ago

Describe the bug setForceSafeFrame is always called. It should only be called when forceSafeFrame is explicitly set.

Problem code is in dfp-ad.directive.ts:

    if (ad.forceSafeFrame !== undefined) {
      this.slot.setForceSafeFrame(true);
    }

Should be:

    if (ad.forceSafeFrame !== false) {
atwwei commented 6 years ago

Thanks for your issue!