search

atx-crypto-club / atxcf

atxcf bot
MIT License
6 stars 3 forks source link

Refactor AllSources for database price storage #21

Closed transfix closed 7 years ago

transfix commented 8 years ago

Right now, AllSources handles writing all source's info to the database. Let's make each individual source responsible for that now that we have the pricedb module so we can simplify things.

transfix commented 8 years ago

Also, lets remove the "prices" and "sources" dictionaries from the settings file so it's not cluttered anymore making it easier to edit by hand. We still might want to keep a local store of price data array's just for performance, but lets use hdf5 or something more suitable for array data.

transfix commented 7 years ago

Since the opening of this issue, I've decided that having AllSources handle the database storage is reasonable. That way, it keeps the individual sources free from that responsibility, making them cleaner to unit test. Also, the settings file no longer contains price data. Instead, it is cached in memcached and also written to the db via the pricedb module. Everything is much happier and playing nicer!