au-ts / libvmm

An experimental virtual machine monitor for the seL4 microkernel
BSD 2-Clause "Simplified" License
21 stars 11 forks source link

VirtIO console early crashing #71

Open erichchan999 opened 1 week ago

erichchan999 commented 1 week ago

As mentioned from #70 , in the virtio example if console.c is invoked too early to handle the receiving of characters, this can cause the VMM to crash. This is due to the serial system notifying the VMM client and its processing that by accessing the virtqueues before it is initialised.

Ivan-Velickovic commented 1 week ago

We should at least be checking the DRIVER_OK bit before doing anything.

Ivan-Velickovic commented 1 day ago

We also wrongly assume that the guest-physical address we're copying out of/into from virtIO descriptors is valid. We should be checking that they always lie within guest RAM.