search

au-ts / lionsos

A secure, fast, and adaptable OS based on the seL4 microkernel
https://lionsos.org
BSD 2-Clause "Simplified" License
84 stars 12 forks source link

Kitty submodules #69

Closed Kswin01 closed 4 months ago

Kswin01 commented 4 months ago

Intialise the required submodules in the Kitty Makefile if they have not yet been initialised.

Ivan-Velickovic commented 4 months ago

If you could make a PR to update the documentation on lionsos.org that would be great as well.

Ivan-Velickovic commented 4 months ago

What happens if you're developing and you change the branch of a submodule, when you run make won't it go back to the checked in commit?

I think this is why we should have a separate make submodules step and make just does the compiling.

Ivan-Velickovic commented 4 months ago

You can look at the webserver, I believe it does this.

Kswin01 commented 4 months ago

What happens if you're developing and you change the branch of a submodule, when you run make won't it go back to the checked in commit?

That's what the git submodule status check was for, to only initialise the submodules if they haven't already been initialised, as denoted by the '-' in front of the submodule.

I think this is why we should have a separate make submodules step and make just does the compiling.

Ok, best to keep it inline with the webserver as well then. I'll make those changes now.

Ivan-Velickovic commented 4 months ago

That's what the git submodule status check was for, to only initialise the submodules if they haven't already been initialised, as denoted by the '-' in front of the submodule.

But then if you do a git pull and run make submodules it won't update anything right?