au-ts / lionsos

A secure, fast, and adaptable OS based on the seL4 microkernel
https://lionsos.org
BSD 2-Clause "Simplified" License
84 stars 7 forks source link

Substitute libco for libmicrokitco to perform blocking I/O in Micropython #72

Closed dreamliner787-9 closed 1 month ago

dreamliner787-9 commented 2 months ago

This pull request:

JE-Archer commented 2 months ago

If you are adding a dependency on libmicrokitco and libmicrokitco contains a copy of libco, why update the libco in the Lions OS repository instead of just removing it?

dreamliner787-9 commented 2 months ago

If you are adding a dependency on libmicrokitco and libmicrokitco contains a copy of libco, why update the libco in the Lions OS repository instead of just removing it?

Just in case someone still need it, but I'm happy to remove it.

Ivan-Velickovic commented 2 months ago

lionsos/libco should be removed. Whether libmicrokitco lives in Microkit, LionsOS, or as its own repo we can discuss later.

Before reviewing this PR I'll first look at design/code for libmicrokitco in more detail.