Tristans i2c fixes n additions

au-ts / sddf

A collection of interfaces, libraries and tools for writing device drivers for seL4 that allow accessing devices securely and with low overhead.

BSD 2-Clause "Simplified" License

13 stars 11 forks source link

Tristans i2c fixes n additions #147

Open TristanCM347 opened 2 weeks ago

TristanCM347 commented 2 weeks ago

added ds3231 device driver
updated and refactored pn532 driver
reorganised them to be outside of example directory and into driver directory
fixed bugs and refactored i2c driver
updated readme for i2c driver to be correct for the current implementation
removed previous pn532 client example
created new ds3231+pn532 example where they both the clients use the bus simultaneously
updated the board for 2 clients
updated queue.h for an extra field
updated the virtualiser so it can facilitate 2 clients instead of 1
added makefiles and readmes to each directory I created.
added an mp4 video showing the card reader working

TristanCM347 commented 2 weeks ago

its failing because I have not updated the zig makefile and I dont know how to fix it :/ ... the regular make file works though.

also I dont know what the style format that needs to be used

omeh-a commented 2 weeks ago

Please squash commits to logical units - e.g. combine "regarding i2c" and "tidied up". Change commit messages to be compact since most people will see these in a terminal - e.g. "I2C: Refactored to (x) and added examples". Do this with a git rebase -i

Ivan-Velickovic commented 2 weeks ago

The main thing that is obvious now that we have an I2C system with multiple clients is that we need some kind of library that abstracts the sDDF layer into a library that can be used by any I2C 'driver' (e.g a PN532 driver or RTC driver).

All of the functionality provided by request_* and response_* should be in a separate library for others to use and not isolated to the example.

That would be good to do before adding to the example further, we can discuss what the API should look like in person with @omeh-a.

Ivan-Velickovic commented 2 weeks ago

The style check is documented here by the way: https://github.com/au-ts/sddf/tree/main/ci.

Ivan-Velickovic commented 1 day ago

its failing because I have not updated the zig makefile and I dont know how to fix it

Can help you fix it before we merge.