au-ts / sddf

A collection of interfaces, libraries and tools for writing device drivers for seL4 that allow accessing devices securely and with low overhead.
Other
17 stars 14 forks source link

blk/mmc: Remove the card detect interrupts from the iMX8 controller #202

Closed midnightveil closed 1 month ago

midnightveil commented 1 month ago

They weren't used anywhere, and wouldn't be handled correctly if they occurred. Also see the notes about card detect on these boards in issue https://github.com/au-ts/sddf/issues/187#issuecomment-2272724337

Peter suggested commenting these out instead of removing entirely (even though they don't seem to work on this platform). Maybe it's better not to link to an issue?

Ivan-Velickovic commented 1 month ago

Makes sense but better not to link to the issue in my opinion. It's in the commit message anyways.

midnightveil commented 1 month ago

Fixed