Add new error codes to sddf block

au-ts / sddf

A collection of interfaces, libraries and tools for writing device drivers for seL4 that allow accessing devices securely and with low overhead.

Other

17 stars 14 forks source link

Closed erichchan999 closed 2 weeks ago

erichchan999 commented 2 weeks ago

BLK_RESP_OK: When request succeeds
BLK_RESP_ERR_UNSPEC: Miscelleanous errors
BLK_RESP_ERR_INVALID_PARAM: Request gives invalid parameters, e.g. passing a physical address thats out of bounds
BLK_RESP_ERR_SEEK: read/write request block number is invalid
BLK_RESP_ERR_NO_DEVICE: can't handle request because the device is unplugged

midnightveil commented 2 weeks ago

You forgot to change existing uses of BLK_RESP_SEEK_ERROR.

Ivan-Velickovic commented 2 weeks ago

BLK_RESP_ERR_NO_DEVICE: can't handle request because the device is unplugged

Should this be BLK_RESP_ERR_NOT_READY instead?

If we want errors specific to the hot-plugging that should be in a separate PR probably with all the other hot-plugging changes.

Ivan-Velickovic commented 2 weeks ago

We should be checking that cli_code is valid and if it is not respond with BLK_RESP_ERR_INVALID_PARAM.

erichchan999 commented 2 weeks ago

We should be checking that cli_code is valid and if it is not respond with BLK_RESP_ERR_INVALID_PARAM.

Yep, I plan to do that in a separate PR along with some other changes to the virtualiser

midnightveil commented 2 weeks ago

This was mostly to unblock me (as I'd asked about the return codes for errors).

erichchan999 commented 2 weeks ago

Yep, I plan to do that in a separate PR along with some other changes to the virtualiser

Nvm scratch that, I'll change those errors codes anyway in this PR and make a separate PR for the virtualiser fixes