search

au2001 / icloud-passwords-firefox

Firefox extension which lets you use your passwords stored on iCloud Keychain®.
https://addons.mozilla.org/en-US/firefox/addon/icloud-passwords/
Apache License 2.0
76 stars 5 forks source link

Improve webpack bundling #23

Open au2001 opened 7 months ago

au2001 commented 7 months ago

The current bundle size is very large because the full React code is included for each page. webpack options should be optimized to reduce the bundle size, including chunking and tree-shaking.

fbender commented 7 months ago

Sorry for dragging my feet on this, a couple of things came up and had to focus somewhere else. Thanks for taking care of the issues. I intend to revisit this project by next week; I‘m still stuck on the previous macOS, which does not provide the API you‘re using for the extension, but intend to upgrade once I manage to close out the other topics on my side.

Now for this issue: I consider this issue may be coupled with #24. I was going to suggest switching to vite as the bundler, which should fix the underlying issue but also provides some extras and plays nice with lightweight UI libraries, without the fuss of configuring much. Would this work for you? It may be a relatively easy first contribution from my side.

au2001 commented 7 months ago

@fbender No worries. Thanks for the time you spend on this. vite would be great indeed. You can open a PR which closes both this issue and #24 at once if you feel like implementing both.