search

au2001 / icloud-passwords-firefox

Firefox extension which lets you use your passwords stored on iCloud Keychain®.
https://addons.mozilla.org/en-US/firefox/addon/icloud-passwords/
Apache License 2.0
129 stars 12 forks source link

Replace React with lightweight UI library #24

Open au2001 opened 10 months ago

au2001 commented 10 months ago

React: While I assume you chose this library for simplicity and your personal experience and DevEx, it's a rather heavy dependency for some small-ish Frontend interaction. Replacing React with WebComponents + JS (or something like lit or even vue for some better DevEx) would go a long way to reduce the footprint. This is certainly a controversial suggestion; if you are open to it, I'd be interested in taking a stab at this.

Originally posted by @fbender in https://github.com/aurelien-garnier/icloud-passwords-firefox/issues/16#issuecomment-1801878020

lit and Svelte are both good options in my opinion.

Originally posted by @aurelien-garnier in https://github.com/aurelien-garnier/icloud-passwords-firefox/issues/16#issuecomment-1802204552

janvhs commented 6 months ago

Honestly, I don’t think it’s really necessary, because it’s an extension one installs only once. However, if you want to use a lighter toolkit, replace React with Preact https://preactjs.com . Setup the compatibility layer as needed.

gagarine commented 1 week ago

React is heavy to parse and execute. I cannot imagine this extension GUI being that complex to need component and all.... and yet. If I have 10 extensions and all use react, it impact the browser performance. It's like running 10 applications.