auQuiksilver / Apex-Framework

Apex Framework
MIT License
81 stars 46 forks source link

(1.5.0b) Earplugs are not taken out properly #42

Open thegamecracks opened 1 year ago

thegamecracks commented 1 year ago

Mission version

1.5.0b at 3f33f6ff5425040316201113dbba680fbba01a1e

Observed Behaviour

When removing earplugs, the mission does not restore my original game volume.

Potential Cause

It looks like the fadeSound command is being misused in fn_clientEarplugs.sqf since they are being given client setting values directly, even though fadeSound applies a scaling factor to those settings.

https://community.bistudio.com/wiki/fadeSound The player's in-game setting is not changed by this command: Final Volume = Client Setting * Scripted Volume.

https://github.com/auQuiksilver/Apex-Framework/blob/3f33f6ff5425040316201113dbba680fbba01a1e/Apex_framework.terrain/code/functions/fn_clientEarplugs.sqf#L19-L27

In my case, getAudioOptionVolumes returns 0.19 and 0.5 for effects and earplugs (map factor) respectively, explaining why removing earplugs didn't raise the volume.

auQuiksilver commented 1 year ago

hey,

yes the system now uses your volumes settings. if the "earplugs in" is your map factor now, allowing you to customize the earplugs vol.

I see what you mean, and will apply a fix soon

auQuiksilver commented 1 year ago

should be resolved

Mobilemick commented 11 months ago

I removed JSRS Sound Mod and it worked fine