Closed magdanowak closed 4 years ago
Merging #9 into develop will decrease coverage by
4.6%
. The diff coverage is20.68%
.
@@ Coverage Diff @@
## develop #9 +/- ##
===========================================
- Coverage 95.58% 90.97% -4.61%
===========================================
Files 18 18
Lines 385 410 +25
===========================================
+ Hits 368 373 +5
- Misses 17 37 +20
Impacted Files | Coverage Δ | |
---|---|---|
nadia/schema.py | 27.27% <20%> (-15.59%) |
:arrow_down: |
nadia/api.py | 35.29% <21.42%> (-21.85%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fe40335...44c158e. Read the comment docs.
Great job, I agree we should probably wait until additionalProperties
issue is fixed (this, in turn, should wait until possible refactor following from #6).
As for the references, they should be automatically handled by ymlref
. However, there is no way of extracting schema names using ymlref
for the time being. I'll see if it can be somehow easily implemented.
Some details:
NadiaCombinedSchema
doesn't recognize and follow referenced schemas,schema_i
in case of validation failure - not the most elegant solution, but maybe some other ideas during review?additionalProperties
implementation (mentioned by @magdanowak in #5), so merging should probably wait until these are resolved