aubergine-developers / nadia

Small and lightweight library for creating marshmallow Schemas for objects defined in OpenAPI 3 specs.
MIT License
1 stars 0 forks source link

Dev/anyof etc #9

Closed magdanowak closed 4 years ago

magdanowak commented 5 years ago

Some details:

codecov-io commented 5 years ago

Codecov Report

Merging #9 into develop will decrease coverage by 4.6%. The diff coverage is 20.68%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #9      +/-   ##
===========================================
- Coverage    95.58%   90.97%   -4.61%     
===========================================
  Files           18       18              
  Lines          385      410      +25     
===========================================
+ Hits           368      373       +5     
- Misses          17       37      +20
Impacted Files Coverage Δ
nadia/schema.py 27.27% <20%> (-15.59%) :arrow_down:
nadia/api.py 35.29% <21.42%> (-21.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe40335...44c158e. Read the comment docs.

dexter2206 commented 5 years ago

Great job, I agree we should probably wait until additionalProperties issue is fixed (this, in turn, should wait until possible refactor following from #6).

As for the references, they should be automatically handled by ymlref. However, there is no way of extracting schema names using ymlref for the time being. I'll see if it can be somehow easily implemented.