search

aubreypwd / wpkickstart

A great way to kickstart a new WordPress plugin or project.
9 stars 0 forks source link

Bring in all boilerplate improvements from RC #3

Closed aubreypwd closed 6 years ago

aubreypwd commented 6 years ago

Details to come after I get a solution in place, but basically in constructs calling app() gets a max-depth issue.

aubreypwd commented 6 years ago

We just need to remove the useless app() function all-together.

https://github.com/aubreypwd/wp-plugin-boilerplate/blob/master/plugin-name.php#L35

We can just bring in the app via global $app if you need it. We also need to have the construct in App class not attach other classes, we should have a go method do that after we create $app:

aubreypwd commented 6 years ago

We can also just run the attach function (which causes the recursion) after we create the $app global:

aubreypwd commented 6 years ago

Renaming this task because all improvements are in this RC plugin including language improvements, etc. Let's just break down that plugin into a new version of the current boilerplate.