search

auchenberg / chrome-devtools-app

Chrome DevTools packaged as an app via Electron
MIT License
1.58k stars 92 forks source link

Adds default menus for OSX. #9

Closed shidel-dev closed 9 years ago

shidel-dev commented 9 years ago

This will close #5.

Adds window and edit menus for osx. This enables minimize, quit, close, copy, paste etc..

I recommend this solution over adding a keyboard event and calling close manually as suggested in #7. The operating system has already implemented this for us.

Crash-- commented 9 years ago

I prefer this way too. I tried several solutions after looking at the nw documentation but I didn't find this one.

Thanks!

But with this solution, the title of the Application is "node-webkit". How to change that?

capture d ecran 2014-12-30 a 20 51 37

And maybe we can test the platform : createMacBuiltin will makes the app crash on other system.

auchenberg commented 9 years ago

Indeed, this approach is much cleaner. We stil need to be able to run the app outside of node-webkit, for debugging purposes, so new $scope.gui.Menu({ type: "menubar" }); needs to be wrapped in a condition to check if $scope.gui is available.

auchenberg commented 9 years ago

@Crash-- I found the solution to the application title problem, https://github.com/auchenberg/chrome-devtools-app/issues/10

Thanks for the contribution :)

shidel-dev commented 9 years ago

@auchenberg for debugging, why not just set the toolbar to true in the package.json so that the devtools in node webkit can be used?

auchenberg commented 9 years ago

You can sure that when debugging, or call the debug method which opens the DevTools. We do want to hide the default browser UI, so that's why toolbar is false.