search

auchenberg / devtools-remote

Debug your browser tabs remotely via Chrome DevTools
https://remote.devtools.rocks
MIT License
687 stars 40 forks source link

No SSL for WebSocket connections #3

Closed auchenberg closed 7 years ago

auchenberg commented 8 years ago

Chrome DevTools doesn't seem to support SSL WebSocket connections.

auchenberg commented 8 years ago

@paulirish Do you know if the DevTools front-end supports WSS?

kzahel commented 7 years ago

I don't see why it wouldn't work: https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/sdk/Connections.js#L117 just passing in wss:// instead of ws:// right?

paulirish commented 7 years ago

I believe the problem may be here: https://github.com/ChromeDevTools/devtools-frontend/blob/32506bf47f1a3d38e5b435ff68ef07abfaac52d7/front_end/sdk/TargetManager.js#L424-L426

  _createMainConnection(params) {
    if (Runtime.queryParam('ws')) {
      var ws = 'ws://' + Runtime.queryParam('ws');

If you guys want, we can add support for a wss query parameter. Assuming this has value to yall..

auchenberg commented 7 years ago

Yup @paulirish the problem is how querystring is used. That would be wonderful! Would close the big security gap when remoting over the wire.

paulirish commented 7 years ago

Nice. does this look about right to you? https://codereview.chromium.org/2729623006

auchenberg commented 7 years ago

@paulirish Yup looks legit 👍

paulirish commented 7 years ago

resolved on the devtools side

auchenberg commented 7 years ago

Now back online at https://remote.devtools.rocks/