search

auchenberg / devtools-remote

Debug your browser tabs remotely via Chrome DevTools
https://remote.devtools.rocks
MIT License
686 stars 40 forks source link

Use correct versionized DevTool front-end #6

Open auchenberg opened 8 years ago

auchenberg commented 8 years ago

Different versions of Chrome supports different features in DevTools, in order to make DevTools Remote work in current and future versions, then it should load the correct versionized DevTool front-end.

Steps:

kurtextrem commented 8 years ago

You may want to detect the Blink version, rather than the WebKit version :)

auchenberg commented 8 years ago

The property is actually still called Webkit-Version as per https://code.google.com/p/chromium/codesearch#chromium/src/components/devtools_http_handler/devtools_http_handler.cc&q=Webkit-versio&sq=package:chromium&type=cs&l=566

kurtextrem commented 8 years ago

Oh, well then. My bad!

kzahel commented 7 years ago

I tried having a Canary (58) connect to current stable (56) and it didn't work so great. There was some flickering on the image. https://github.com/auchenberg/devtools-remote/blob/master/server.js#L111 'chrome-devtools://devtools/remote/serve_rev/@d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa/inspector.html?ws=' + webSocketUrl + '&remoteFrontend=true&dockSide=unlocked&experiments=true'

It looks like you hard coded in a revision. Can you describe the process by which you selected that revision?

auchenberg commented 7 years ago

@kzahel The DevTools version is selected on a per-commit basis. No special policy or process.