search

auchenberg / volkswagen

:see_no_evil: Volkswagen detects when your tests are being run in a CI server, and makes them pass.
MIT License
14.09k stars 234 forks source link

third party noop library #92

Open grantholly opened 5 years ago

grantholly commented 5 years ago

Following software design best practices I'm not going to be rolling my own noop (you jsut don't do that)

This addresses https://github.com/auchenberg/volkswagen/issues/90

grantholly commented 5 years ago

Awesome, looks like tests passed.

relative2 commented 5 years ago

Hey @grantholly if you weren't aware already, you haven't uploaded your PGP key to GitHub yet.

jpike88 commented 5 years ago

what the hell did I just read

Guria commented 5 years ago

At first look, I was very sceptic about this change. But I appreciate this, after a closer look at node-noop repo. It is another seriously joking package which has solid tests and even benchmarks.