search

auchenberg / vscode-browser-preview

A real browser preview inside your editor that you can debug.
MIT License
4.39k stars 153 forks source link

"Updated" notification popping up semi-frequently #189

Closed vith closed 3 years ago

vith commented 3 years ago

https://github.com/auchenberg/vscode-browser-preview/blob/f3c9ceef3162be248cf50a926eb11695f12c0323/ext-src/telemetry.ts#L67

I'm not sure what this is supposed to mean to me as a user; for a long time I didn't know what extension was causing it. I think I see this pop up a few times a day for some reason.

Is this just leftover debugging that can be removed? Or maybe the message can be clarified, and/or only be displayed if some relevant configuration key actually changed?

auchenberg commented 3 years ago

@vith Good catch, yes this should be removed.

jamilraichouni commented 3 years ago

Hi!

First: Thanks for that extension! Second: May you publish a new release where that message disappears?

Temporary I removed the line 51

vscode.window.showInformationMessage('Updated');

from the function configurationChanged in the file extensions/auchenberg.vscode-browser-preview-0.7.0/build/ext-src/telemetry.js.

Thank you, Jamil

auchenberg commented 3 years ago

@jamilraichouni Done