search

auchenberg / vscode-browser-preview

A real browser preview inside your editor that you can debug.
MIT License
4.39k stars 154 forks source link

#31 enable audio by ignoring flag in chromium default args #206

Closed AlaaMouch closed 2 years ago

AlaaMouch commented 3 years ago

Audio in headless chromiums was muted back in 2017, in this precise commit: https://github.com/puppeteer/puppeteer/commit/1ca784901743792726e3896ed4d4809a66d6a213

Also, this exact solution seems to be referenced in the API Documentation, albeit with no useful context.

This PR would fix #31 and #140, as far as I'm concerned.