search

audaciaconsulting / Audacia.CodeAnalysis

MIT License
1 stars 4 forks source link

SA1010 reporting on incorrect spacing #19

Closed jackpercy-acl closed 9 months ago

jackpercy-acl commented 9 months ago

SA1010 says there should not be a space here, but there should be:

image

If you apply the fix, SA1002 and IDE0055 both report an issue:

image

Think this is because the version of StyleCop.Analyzers referenced in Audacia.CodeAnalysis is not aware of a lot of C#11 features.

There is a somewhat related issue here: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3503

Updating StyleCop.Analyzers locally to 1.2.0-beta.556 fixes the issue:

image

I have had a skim through the changelogs of StyleCop.Analyzers and cannot see any big changes, mostly seems like tweaks to existing rules in order to support newer C# features, so should be an easy upgrade