audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
777 stars 104 forks source link

Audacious: cannot enable libarchive at configure time. #1346

Closed Audacious-Bot closed 1 month ago

Audacious-Bot commented 1 month ago

Author Name: Carlo Bramini Original Redmine Issue: https://redmine.audacious-media-player.org/issues/1206 Original Date: 2023-03-14


I tried to enable libarchive by adding @--enable-libarchive@ when calling configure. During the process, it prints on the console:

checking for libarchive... no
configure: error: Package requirements (libarchive) were not met:

Package 'iconv', required by 'libarchive', not found
</code>

Into the macro @PKG_CHECK_MODULES()@ provided by aclocal, @_PKG_CONFIG()@ is also used for testing the dependecies into *_LIBS. Evidently, libarchive depends also on libiconv here. But GNU Iconv does not provide a script for pkgconfig. Both the latest version 1.17 of Libiconv and its development sources at Savannah have not it. At the moment, I bypassed the problem by writing by hand an iconv.pc file, which allowed me to complete the configuration and make a successful build.

I tested this behaviour with the latest development sources of Audacious after release of version 4.3. The build platforms are MinGW and CYGWIN.

Audacious-Bot commented 1 month ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2023-03-15T16:56:58Z


This seems like a libarchive packaging issue; do you have reason to believe otherwise?

Audacious-Bot commented 1 month ago

Original Redmine Comment Author Name: Carlo Bramini Original Date: 2023-03-16T14:01:23Z


John Lindgren wrote:

This seems like a libarchive packaging issue; do you have reason to believe otherwise?

This is the content of libiconv provided by Arch Linux, just click the link inside the "Package Contents" section to open the drop-down list:

https://archlinux.org/packages/community/x86_64/libiconv/

and there is not a iconv.pc file to be used with pkg-config. However, this issue seems to be related only to autotools configure, since Meson detects both libarchive and iconv correctly.

Audacious-Bot commented 1 month ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2023-03-18T02:51:58Z


Carlo Bramini wrote:

and there is not a iconv.pc file to be used with pkg-config.

Right, so it is wrong for libarchive to declare (via pkg-config) a dependency on iconv. See https://github.com/libarchive/libarchive/issues/1819.

Arch Linux patches out the iconv dependency from its libarchive package, for what it's worth: https://github.com/archlinux/svntogit-packages/blob/8609f0893f709461260da7f92dbcdd21ec85e287/trunk/PKGBUILD#L41

Closing since this is a libarchive issue.