audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
802 stars 106 forks source link

Make "About" always enabled for plugins #1420

Open birdie-github opened 3 weeks ago

birdie-github commented 3 weeks ago

The About button for plug-ins is in the disabled state unless the plugin is enabled which is kinda counter-intuitive since you may want to learn what the plugin does before enabling it.

mschwendt commented 3 weeks ago

Why not enable it and disable it again? Quick and efficient.

To access the plugin information dialog, Audacious would need to load a plugin. It sounds cumbersome to do that for all plugins, even if a different implementation might only cache that information for later use. Also, for most plugins that button doesn't tell what the plugin does, but it only displays credits and possibly the licensing.

birdie-github commented 3 weeks ago

To access the plugin information dialog, Audacious would need to load a plugin.

Plugins are already sort of loaded on start-up.

It sounds cumbersome to do that for all plugins, even if a different implementation might only cache that information for later use.

This can be done on a per-plugin basis or the plugin API could be changed to avoid this altogether.

Also, for most plugins that button doesn't tell what the plugin does, but it only displays credits and possibly the licensing.

And that's just bad and should be fixed as well.

mschwendt commented 3 weeks ago

Once registered, a known but disabled plugin won't be loaded.