audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
871 stars 116 forks source link

Update config.guess and config.sub #1458

Open LinuxResearcher opened 2 months ago

LinuxResearcher commented 2 months ago

Describe the bug Can't be built on some new instruction set computer.

Steps to reproduce When I build audacious, I get some error information like this:

checking build system type... ./build-aux/config.guess: unable to guess system type

This script, last modified 2013-06-10, has failed to recognize
the operating system you are using. It is advised that you
download the most up to date version of the config scripts from

  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
and
  http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD

If the version you run (./build-aux/config.guess) is already up to date, please
send the following data and any information you think might be
pertinent to <config-patches@gnu.org> in order to provide the needed
information to handle your system.

config.guess timestamp = 2013-06-10

uname -m = loongarch64
uname -r = 6.10.0-2
uname -s = Linux
uname -v = #1 SMP PREEMPT Mon, 19 Aug 2024 06:05:26 +0000

/usr/bin/uname -p = unknown
/bin/uname -X     = 

hostinfo               = 
/bin/universe          = 
/usr/bin/arch -k       = 
/bin/arch              = 
/usr/bin/oslevel       = 
/usr/convex/getsysinfo = 

UNAME_MACHINE = loongarch64
UNAME_RELEASE = 6.10.0-2
UNAME_SYSTEM  = Linux
UNAME_VERSION = #1 SMP PREEMPT Mon, 19 Aug 2024 06:05:26 +0000
configure: error: cannot guess build type; you must specify one

In order to build audacious, we must replace config.guess and config.sub with the latest version. Config.guess and config.sub in Audacious is 11 years ago, It is too old to build on some new instruction set computer, like loongarch, riscv64, etc.

Expected behavior So, could you place update config.guess and config.sub to the latest version for audacious and audacious-plugins? Sorry for my terrible English.

Additional information

radioactiveman commented 2 months ago

Have you tried updating the files? Does the build work then on your system? And we recommend to use Meson for building Audacious. Autotools support is only kept for backwards compatibility.

@jlindgren90: Do you think we should update the files? I can't estimate the risk of regressions.

LinuxResearcher commented 2 months ago

Have you tried updating the files? Does the build work then on your system? And we recommend to use Meson for building Audacious. Autotools support is only kept for backwards compatibility.

@jlindgren90: Do you think we should update the files? I can't estimate the risk of regressions.

Hello! Yes, I updated the files and build successfully on my system with using configure. And by my test, if I havent update the files, I can build successfully with using Meson. I noticed meson.build just after your reply, Thanks!

jlindgren90 commented 2 months ago

Updating config.guess and config.sub is probably fine, but I would not do it between point releases (4.4.x). Just prior to a 4.5-beta would be a good time.