error dialog when opening cue file with non-ascii characters

FelipeLema commented 2 months ago

Describe the bug I get an error dialog when dragging a .cue file with japanese characters. VLC plays the same file just fine.

Steps to reproduce Explained in bug description.

Expected behavior Audacious plays the cue file like any other (this one file is the one I have problems with).

Additional information

Audacious version and interface (Qt / GTK / Winamp): Qt
Operating system and version: Devuan (systemd-less Debian fork)
Desktop environment: KDE plasma
Screenshots

Sample files Here is the content, and here is the actual file

REM GENRE Game
REM DATE 1991/07/21
REM DISCID EF0A9212
REM COMMENT ExactAudioCopy v0.99pb4
PERFORMER "Falcom Sound Team J.D.K."
TITLE "パーフェクト·コレクション·ソーサリアン DISC1"
FILE "CDImage.flac" WAVE
TRACK 01 AUDIO
TITLE "オープニング"
INDEX 01 00:00:00
TRACK 02 AUDIO
TITLE "城「ここで逢えるね」"
INDEX 01 01:12:70
TRACK 03 AUDIO
TITLE "町「ペンタウアⅠ」"
INDEX 01 03:39:47
TRACK 04 AUDIO
TITLE "町「ペンタウアⅡ」"
INDEX 01 05:56:17
TRACK 05 AUDIO
TITLE "消えた王様の杖 - ダンジョン"
INDEX 01 07:51:22
TRACK 06 AUDIO
TITLE "消えた王様の杖 - ヒドラ"
INDEX 01 09:53:12
TRACK 07 AUDIO
TITLE "消えた王様の杖 - 生還"
INDEX 01 12:11:10
TRACK 08 AUDIO
TITLE "消えた王様の杖 - トラベラーズ·イン"
INDEX 01 14:23:50
TRACK 09 AUDIO
TITLE "失われたタリスマン - 森"
INDEX 01 16:49:17
TRACK 10 AUDIO
TITLE "失われたタリスマン - 地下ダンジョン"
INDEX 01 19:00:50
TRACK 11 AUDIO
TITLE "失われたタリスマン - 神官デルヒテ"
INDEX 01 21:16:25
TRACK 12 AUDIO
TITLE "失われたタリスマン - サンド·マリボー"
INDEX 01 23:53:17
TRACK 13 AUDIO
TITLE "ルシフェルの水門 - 地下ダンジョン"
INDEX 01 26:11:17
TRACK 14 AUDIO
TITLE "ルシフェルの水門 - クラーケン"
INDEX 01 30:39:07
TRACK 15 AUDIO
TITLE "ルシフェルの水門 - ブラディー·リバー"
INDEX 01 32:08:22
TRACK 16 AUDIO
TITLE "呪われたオアシス - 砂漠"
INDEX 01 36:06:30
TRACK 17 AUDIO
TITLE "呪われたオアシス - 砂の城"
INDEX 01 39:23:25
TRACK 18 AUDIO
TITLE "呪われたオアシス - ルワンとゴールド·ドラゴン"
INDEX 01 42:56:72

Logs (use LANG=C audacious -V for English output)

...
WARNING charset.cc:74 [whine_locale]: Cannot convert to locale (ANSI_X3.4-1968): /home/…/DISC 1/CDImage.cue
INFO adder.cc:235 [add_playlist]: Adding playlist: file:///home/…/DISC%201/CDImage.cue
INFO playlist-files.cc:49 [playlist_load]: Loading playlist file:///home/…/DISC%201/CDImage.cue.
INFO playlist-files.cc:62 [playlist_load]: Trying playlist plugin Cue Sheet Plugin.
INFO plugin-load.cc:64 [plugin_load]: Loading plugin: /usr/lib/x86_64-linux-gnu/audacious/Container/cue.so.
WARNING charset.cc:74 [whine_locale]: Cannot convert to locale (ANSI_X3.4-1968): /home/…/DISC 1/CDImage.cue
INFO probe-buffer.cc:30 [ProbeBuffer]: <0x7f7e10003890> buffering enabled for file:///home/…/DISC%201/CDImage.cue
INFO vfs.cc:105 [VFSFile]: <0x7f7e10003890> open (mode r) file:///home/…/DISC%201/CDImage.cue
bad character '�'
bad character '�'
bad character '�'
119: syntax error

jlindgren90 commented 2 months ago

I can reproduce, but the issue seems to be in libcue. Maybe it does not support UTF-8 properly. The "bad character" error is from here: https://github.com/lipnitsk/libcue/blob/7176a1faccecbfe2d4cca2f776177439ca49cad2/cue_scanner.l#L138

FelipeLema commented 2 months ago

thanks for the quick answer

will open an issue there. If y'all don't mind I'll keep this one open until a version that fixes such issue is pulled in for this repo

audacious-media-player / audacious

error dialog when opening cue file with non-ascii characters #1459