audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
816 stars 109 forks source link

modplug plugin includes sys/mman.h but it doesn't seem to need it. #270

Closed Audacious-Bot closed 5 months ago

Audacious-Bot commented 5 months ago

Author Name: Carlo Bramini Original Redmine Issue: https://redmine.audacious-media-player.org/issues/136 Original Date: 2012-06-23


The file:

src/modplug/archive/arch_raw.cxx

includes sys/mman.h but it does not seem to be required. Instead, it looks like that there are not sources using mmap() and unmap() stuff and this file is the only one that it includes it. Actually, the inclusion of this file breaks the compilation of the plugin: if it is not required by some platform or for some reason, it would be better to remove it or at least make it conditional.

On previous version, I was able to make it working by simply removing that line; on newer version in the repository, I do not know what it happens, since I'm still trying to make working GTK+3 on my mingw+msys.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2012-06-24T14:16:17Z


Fixed.