search

audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
871 stars 115 forks source link

modplug plugin still fails to compile on Windows. #280

Closed Audacious-Bot closed 6 months ago

Audacious-Bot commented 6 months ago

Author Name: Carlo Bramini Original Redmine Issue: https://redmine.audacious-media-player.org/issues/146 Original Date: 2012-07-07

I'm still getting an error when compiling modplug plugin with a not hacked Windows SDK. The problem is into src/modplug/modplugbmp.cxx, in the implementation of method PlayLoop in ModplugXMMS class: in the processing of the block related to mModProps.mPreamp, there are some variables declared as "uint". This type does not exists in PSDK and in the official W32API package, so I would like to suggest to change them to "uint32_t", which is the same type used for mBufSize.

Attached patch fixes this behavior.

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2012-07-08T15:40:36Z

This is already fixed in Git: https://github.com/audacious-media-player/audacious-plugins/commit/447ab350d0b4b7757153d5762f13eb2cfbf12583