audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
871 stars 115 forks source link

Configuration GUI for modplug #367

Closed Audacious-Bot closed 6 months ago

Audacious-Bot commented 6 months ago

Author Name: Matthew Stapleton Original Redmine Issue: https://redmine.audacious-media-player.org/issues/233 Original Date: 2012-12-30


Since around 7 September 2011 the modplug plugin has been missing the gui code to configure the preferences.

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: Michael Schwendt Original Date: 2012-12-30T13:52:16Z


Very likely it's just waiting for a volunteer to contribute patches that add it back, porting it GTK+ 3 or even Audacious Preferences UI API.

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: Vladimir Strakh Original Date: 2013-04-19T01:24:05Z


Hi all.

I've been missing modplug preferences too. Googling around brought me here, and I found out that preferences is not a priority. So, here's my small contribution - patch that adds preferences page to modplug plugin. It's implemented in terms of Audacious Preferences UI API, and I tried to keep its look as close as possible to old page.

Any chances that it will be accepted?

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-04-20T05:01:22Z


Hi Vladimir, I've committed an adapted version of your patch: https://github.com/audacious-media-player/audacious-plugins/commit/55b332ef8c97852fd6fa3b4b4a5cf0cdc0638ee6

Thank you for the contribution; I'm sure it will make a lot of modplug users happy.

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-04-20T05:03:30Z


Just to double-check: are you okay with this code entering the public domain (since that's how the rest of the plugin is licensed)?

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: Vladimir Strakh Original Date: 2013-04-20T07:44:52Z


Going public domain is absolutely ok :) thx.