audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
872 stars 116 forks source link

FTBS : audacious-plugins-3.3.4 - sndio.plugin uses strlcpy which is a libbsd function, so libbsd is needed #411

Closed Audacious-Bot closed 6 months ago

Audacious-Bot commented 6 months ago

Author Name: James Gregory Miller Original Redmine Issue: https://redmine.audacious-media-player.org/issues/277 Original Date: 2013-04-09


PRETTY_NAME="Ubuntu quantal (12.10)" VERSION="12.10, Quantal Quetzal"

When building audacious-plugins-3.3.4, if the header files and library for sndio are found,

Sndio (sndio): yes

Successfully compiled sndio.c (plugin).

sndio.plugin.o: In function configure_win_ok_cb': /home/Temp/Build/audacious-plugins-3.3.4/src/sndio/sndio.c:383: undefined reference tostrlcpy' collect2: error: ld returned 1 exit status

strlcpy in Debian/Mint/Ubuntu is found in libdsd/libsd-dev, so when the checks for sndio are being performed the presence of libsd and its header files should be checked, and -lbsd added to the LIBS in

audacious-plugins-3.3.4/src/sndio/Makefile

--- Makefile.OLD 2013-02-03 20:09:33.000000000 +0000 +++ Makefile 2013-04-09 17:58:38.830697691 +0100 @@ -9,4 +9,4 @@

CFLAGS += ${PLUGIN_CFLAGS} CPPFLAGS += ${PLUGIN_CPPFLAGS} ${GTK_CFLAGS} ${GLIB_CFLAGS} -I../.. -LIBS += ${GTK_LIBS} ${GLIB_LIBS} ${SNDIO_LIBS} +LIBS += ${GTK_LIBS} ${GLIB_LIBS} ${SNDIO_LIBS} -lbsd

Audacious-Bot commented 6 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-04-10T01:53:36Z


Fixed for 3.4: https://github.com/audacious-media-player/audacious-plugins/commit/f17617a38d8412ca30750775208733dc1287e122