audacious-media-player / audacious

A lightweight and versatile audio player
https://audacious-media-player.org
Other
817 stars 109 forks source link

Slow file content probing #420

Closed Audacious-Bot closed 5 months ago

Audacious-Bot commented 5 months ago

Author Name: Anonymous Original Redmine Issue: https://redmine.audacious-media-player.org/issues/286 Original Date: 2013-04-28


Hello all. I'm using v3.3.4 in Debian Wheezy.

I like to keep my audio files without filename extensions.

Audacious reads and plays extensionless mp3 files perfectly quickly, displays immediately, and is able to get +all+ the metadata (from tag and otherwise, including things like bitrate) when you open song info for a track.

It plays extensionless ogg and flac files immediately, but the player hangs about a minute (especially on flac files) before displaying anything in the GTK interface, and also does not give album, track number or bitrate. Strangely it does give the title, artist, comment and year, even when the folder names don't include year.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-04-29T00:03:07Z


Please attach an example file; otherwise there's no way for anyone to help you.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: Anonymous Original Date: 2013-04-29T01:07:19Z


okay, for your testing pleasure, here's a clip of Rose Royce's "Ooh Boy"

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-04-29T04:34:50Z


See if these commits help: https://github.com/audacious-media-player/audacious/commit/c6d076aad9fc9fc2551ed8e150a62d6e60570628 https://github.com/audacious-media-player/audacious-plugins/commit/a3230bbc3b1f500b06511e6f402915819d22e2a3

I couldn't reproduce anything near a one-minute delay here, though.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: Anonymous Original Date: 2013-04-29T06:10:57Z


sorry, i'm in over my head here. i don't know how to install those commits. unless it's easy enough to explain in a post i guess i'll just wait until it hits the next release. i appreciate you looking at this. i was wondering though, aside from not being able to reproduce the long delays, were you able to reproduce the behavior of not seeing all the vorbis tag info or bitrate info? the rrob.ogg file i included above contains:

Nominal bitrate: 256.000000 kb/s Upper bitrate not set Lower bitrate not set User comments section follows... TITLE=Ooh Boy ARTIST=Rose Royce ALBUM=In Full Bloom TRACKNUMBER=03 DATE=1977 COMMENT=test comment Vorbis stream 1: Total data length: 7931842 bytes Playback length: 4m:16.506s Average bitrate: 247.380455 kb/s

but when i remove the filename extension and play in Audacious I only see the attached image, no bitrate or tracknumber, and no album in song info window but album "r" in the main window. the track is located in a folder called "r". also curious, if it's "Unknown sndfile", how is it able to know the vorbis comment and year?

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: Michael Schwendt Original Date: 2013-04-29T21:43:14Z


To Ryan:

You can run "audacious -V FILENAMEHERE" in your favourite terminal and observe what it does when it tries to recognise the file contents. Depending on what input plug-ins are enabled, several of the plug-ins try to examine the file data, which takes some time. That's not the case when the file extension is present and the .flac plugin is tried first. If the extension is missing, note that the "sndfile" plug-in (based on libsndfile) can handle FLAC, too, and may play the file instead of the "flacng" plug-in.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-05-01T01:09:59Z


The sndfile plugin was grabbing Ogg Vorbis files here without the .ogg extension; that's why I lowered its priority.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: Michael Schwendt Original Date: 2013-05-01T21:33:05Z


Understood. I tried ext-less FLAC files here due to the original comment in the bug report. Quoting:

??> but the player hangs about a minute (especially on flac files)??

It doesn't hang so long, but displays "Buffering" for several seconds, and the sndfile plugin also took the FLAC files.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-05-03T01:08:24Z


I cannot reproduce any noticeable delay here when playing a 10-minute FLAC file with no extension.

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: Michael Schwendt Original Date: 2013-05-03T09:16:43Z


Here the MPG123 based madplug.so does a lot of vfs seeking, causing a noticable delay of several seconds. Full log:

http://mschwendt.fedorapeople.org/tmp/audacious-ext-less-flac-loading.log.gz

$ audacious -V flac ... probe.c:65 [probe_func]: VFS: <0x22f6d00> seek to 0 from beginning probe.c:65 [probe_func]: Trying MPG123 Plugin. pluginenum.c:63 [plugin_load]: Loading plugin: /usr/lib64/audacious/Input/madplu g.so. Trying MPG123 Plugin. mpg123.c:66 [aud_mpg123_init]: initializing mpg123 library VFS: <0x22f6d00> size = 37995628 VFS: <0x22fa280> size = 37995628 VFS: <0x22f6d00> seek to 0 from end VFS: <0x22fa280> seek to 0 from end VFS: <0x22f6d00> tell = 37995628 VFS: <0x22fa280> tell = 37995628 VFS: <0x22f6d00> seek to -128 from end VFS: <0x22fa280> seek to -128 from end

... thousands of times ...

VFS: <0x22fa280> seek to -3 from current VFS: <0x22fa280> tell = 28901037 VFS: <0x22fa280> seek to -3460 from current VFS: <0x22fa280> tell = 28901041 mpg123.c:122 [mpg123_probe_for_fd]: Probe error: A generic mpg123 error. VFS: <0x22fa280> seek to 0 from beginning probe.c:65 [probe_func]: Trying OpenPSF PSF1/PSF2 Decoder. probe.c:65 [probe_func]: Trying Sndfile Plugin.

$ grep ^VFS LOG|wc -l 70546

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-05-04T01:25:56Z


That should have been fixed by c6d076aa. Are you running Git master?

Audacious-Bot commented 5 months ago

Original Redmine Comment Author Name: John Lindgren Original Date: 2013-05-09T01:05:40Z


I'm going to assume this is fixed until shown otherwise.