Error dialog popup during playback on Windows

[Audacious-Bot]

---

Author Name: Bruce Olney Original Redmine Issue: https://redmine.audacious-media-player.org/issues/628 Original Date: 2016-03-12

---

See attached screen Capture.PNG.

These occur when changing songs. But not on every song. Playback continues uninterrupted.

The popup interrupts whatever application has focus. Close the pop-up and focus returns to interrupted application.

I'm not completely sure, but they seem to happen less often on version 3.7.1. They happened more often on version 3.7.

Thanks!

[Audacious-Bot]

---

Original Redmine Comment Author Name: Bruce Olney Original Date: 2016-03-12T00:55:40Z

---

Note: The message pops up when switching to a new song. The file indicated in the dialog is the song that has just finished playing.

[Audacious-Bot]

---

Original Redmine Comment Author Name: Bruce Olney Original Date: 2016-03-12T02:02:02Z

---

I've also noticed that it is specific files that cause the message. Every time these files play, the pop-up message is displayed.

Would it be useful to send you one of the files?

[Audacious-Bot]

---

Original Redmine Comment Author Name: John Lindgren Original Date: 2016-03-13T21:45:56Z

---

Yes, please, if you could attach one of the files, that would be most helpful.

[Audacious-Bot]

---

Original Redmine Comment Author Name: Bruce Olney Original Date: 2016-03-14T18:49:03Z

---

Playing the attached file causes the popup error dialog.

Let it play all the way through. The error dialog is displayed just as audacious starts the next track.

I note that in listening to this track there is a lot of silence at the end. Could the length be incorrect?

Thanks!

[Audacious-Bot]

---

Original Redmine Comment Author Name: John Lindgren Original Date: 2016-03-18T04:32:51Z

---

mpg123 and mp3check both agree that there is junk at the end of the file (starting at byte offset 4,402,739). It looks like it's part of an ID3 tag that some crappy tag editor left there when saving the file.

If you had looked at the console output (unfortunately, it's difficult to see it in Windows; you have to redirect it to a file), you would have seen something like this:

ERROR mpg123.cc:285 [print_mpg123_error]: mpg123 error in file:///.../16.%20Night%20Sky.mp3: Failed to find valid MPEG data within limit on resync. (code 28)

In a future version, we should look into making the error message in the GUI more useful.

[Audacious-Bot]

---

Original Redmine Comment Author Name: Bruce Olney Original Date: 2016-03-22T04:17:39Z

---

These files play on every other media player I have tried with no problems, errors or warnings. I probably ripped them myself a long time ago. I have no idea what codec or software was used.

I have hundreds of these files. I would prefer that no errors are indicated to the user.

[Audacious-Bot]

---

Original Redmine Comment Author Name: Bruce Olney Original Date: 2016-03-28T19:35:18Z

---

That's too bad. This makes Audacious pretty much unusable for me.

[Audacious-Bot]

---

Original Redmine Comment Author Name: xyz dragon Original Date: 2016-04-19T19:41:25Z

---

I also have some of these bad files and I agree, this warning is pretty obtrusive. Why not deactivate the dialog from appearing? Isn't a log message to the console enough, if it doesn't hinder playing?

[Audacious-Bot]

---

Original Redmine Comment Author Name: xyz dragon Original Date: 2016-04-19T19:59:32Z

---

xyz dragon wrote:

I also have some of these bad files and I agree, this warning is pretty obtrusive. Why not deactivate the dialog from appearing? Isn't a log message to the console enough, if it doesn't hinder playing? E.g. by introducing some kind of option or just commenting out lines 364-367 in audacious/src/libaudcore/playback.cc in the latest git commit, i.e. 4558f917754dad51c04

//aud_ui_show_error (str_printf (_("Error playing %s:\n%s"),
// (const char *) pb_info.filename, pb_info.error_s ?
// (const char *) pb_info.error_s : _("Unknown playback error "
// "(check the console for detailed error information)")));

[Audacious-Bot]

---

Original Redmine Comment Author Name: John Lindgren Original Date: 2016-05-12T05:22:01Z

---

Pragmatically, it seems there are enough broken MP3s out there that we should silence this particular error. Fixed.