search

audacity / audacity

Audio Editor
https://wiki.audacityteam.org/wiki/For_Developers
Other
12.3k stars 2.25k forks source link

Alignment of Trackname in TCP and the Clip-handle drag-bars #1474

Closed petersampsonaudacity closed 3 years ago

petersampsonaudacity commented 3 years ago

Discussed in https://github.com/audacity/audacity/discussions/1473

Originally posted by **petersampsonaudacity** August 13, 2021 **Describe the bug** The trackname in Track Control Panel (TCP) is not aligned with the Clip-handle drag-bars (AKA "affordances") **To Reproduce** 1) Get some audio 2) Observe the mis-alignment **Expected behavior** Either: a) the height of the Clip-handle drag-bar to be reduced to the same size as the Track Name field in the TCP, or b) the height of the Track Name field in the TCP to be enlarged to be the same height as the Clip-handle drag-bar. **Screenshots** Image magnified x 2.5 ![image](https://user-images.githubusercontent.com/50205984/129359126-833506c3-7d4c-445c-9163-add5daa177c3.png) **Additional information (please complete the following information):** - Windows 10 - but assume all OS - Audacity 3.1.0/3.0.4 **Additional context** It would just look much neater and more visually pleasing if the two were in alignment. It would be good to get this aesthetically right from the outset when Clip-handle drag-bars are first released to the users,
petersampsonaudacity commented 3 years ago

I had to initiate this as a "Discussion" and then get it transferred using "Create issue from discussion" - as when I tried to just create the Issue the "Submit new issue" is faded out and inaccessible/un-clickable:

image

LWinterberg commented 3 years ago

as when I tried to just create the Issue the "Submit new issue" is faded out and inaccessible/un-clickable

Was that because you didn't enter a title?

petersampsonaudacity commented 3 years ago

as when I tried to just create the Issue the "Submit new issue" is faded out and inaccessible/un-clickable

Was that because you didn't enter a title?

Yes Leo, embarrassingly so (blushes very deeply and face-palms)

petersampsonaudacity commented 3 years ago

@jounih wrote in the associated Issue #1473

18px for the clip handle bars sounds fine and looks like it would fix this. @Paul-Licameli or @vsverchinsky could you please update kAffordancesAreaHeight to 18px? And please send a link to the build to me/Martin once done, so we can check visually. Thanks

Paul-Licameli commented 3 years ago

I see your screenshot and I wonder if you have been playing with the goniometer again.

petersampsonaudacity commented 3 years ago

I see your screenshot and I wonder if you have been playing with the goniometer again.

Actually @Paul-Licameli I did in the past test the Goniometer with Sgt Pepper album ;-)

petersampsonaudacity commented 3 years ago

redundant comment removed - I can't delete the post

petersampsonaudacity commented 3 years ago

Testing on W10 with latest alpha build audacity-win-3.0.4-alpha-20210820+45a90e3-64bit

This tests good for this - the Clip-handle (and the box at the top of the Vertical Scale) is the same height and aligns nicely with the track name in the TCP.

I think this issue can be closed.

image

And note that Audacity now just has the single Clip-handle drag-bar affordance for a stereo track

AnitaBats commented 3 years ago

Closed due to the comment from @petersampsonaudacity