audacity / audacity

Audio Editor
https://wiki.audacityteam.org/wiki/For_Developers
Other
12.59k stars 2.26k forks source link

"Redoing" a realtime effect results in a crash #3074

Closed Ryan-Miller-Audacity closed 2 years ago

Ryan-Miller-Audacity commented 2 years ago

Describe the bug In testing of #2985, it was noted that after undoing and then redoing an effect attempting to open the effect settings in the Realtime Effect UI results in a crash.

https://user-images.githubusercontent.com/88568755/173657163-ba951b33-6083-4c35-a7a9-6598595f707a.mp4

To Reproduce Steps to reproduce the behavior:

  1. Open Audacity
  2. Generate a tone/add some audio
  3. Add a realtime effect like reverb or wahwah via the effects side panel
  4. Click the gear icon, edit the sliders for the effect, and click OK
  5. Go to Edit -> Undo
  6. Click the gear icon and note the changes were undone
  7. Go to Edit -> Redo
  8. Click the gear icon
  9. Audacity Crashes

Actual behavior Audacity crashes when attempting to open realtime effect settings after "redoing" a previously undone effect

Expected behavior Users should be able to open the effect settings after redoing a previously undone effect

Screenshots Screencast included in the summary above.

Additional information (please complete the following information):

Additional context N/A

petersampsonaudacity commented 2 years ago

Testing on W10 with @Paul-Licameli 's branch build "Sidebar bugs": https://github.com/audacity/audacity/actions/runs/2497329369

This now works properly - so PR #3075 fixes this - in Paul's branch

pietro68 commented 2 years ago

Verified it is fixed on a3b3b53

petersampsonaudacity commented 2 years ago

Tested on W10 with latest master audacity-win-3.2.0-alpha-20220623+2fd21af-x64-msvc2022

This works fine with no crash

dozzzzer commented 2 years ago

Verified on Win10 & MacOS