search

audacity / audacity

Audio Editor
https://wiki.audacityteam.org/wiki/For_Developers
Other
11.9k stars 2.23k forks source link

Applying destructive effect to part or all of a time stretched clip results in waveform color reverting to default #5465

Open petersampsonaudacity opened 8 months ago

petersampsonaudacity commented 8 months ago

Bug description

Applying destructive effect to part or all of a time stretched clip results in clip color reverting to default blue waveform.

Generators do not change the waveform color back to default.

Steps to reproduce

  1. Create an audio track which contains a clip.
  2. Time stretch the clip.
  3. Change the Wave Color from the TCP context menu
  4. Select either all or part of the clip
  5. Apply a destructive effect, e.g. Amplify
  6. Observe: the selection reverts to default blue waveform

Expected behavior

The selection should retain the waveform color set at Step 3

Actual behavior

the selection reverts to default blue waveform

Audacity Version

3.4.0

Operating system

Windows

Additional context

Change Pitch/Tempo effects do NOT exhibit this color change

petersampsonaudacity commented 8 months ago

In related bug #5461

@Paul-Licameli wrote:

Now what about preserving clip colors?

I see the fix for clip name and I think we really need the EmptyCopy equivalent for WaveClip as for WaveTrack to copy, name, color, and whatever other et ceteras we might associate with clips in future.

To which @LWinterberg replied:

that sounds like an excellent utility to add for the future :)

petersampsonaudacity commented 3 weeks ago

@dozzzzer @LWinterberg

Testing on W10 with 3.5.1 and the latest alpha master rest build for 3.6.0

I can no longer reproduce this.

I think this bug/issue can ve closed.

dozzzzer commented 3 weeks ago

I can still reproduce this on Windows and macOS in the latest master build.