audacity / audacity

Audio Editor
https://wiki.audacityteam.org/wiki/For_Developers
Other
11.8k stars 2.21k forks source link

Real time compressor and limiter: accessibility names of sliders #6475

Open DavidBailes opened 1 month ago

DavidBailes commented 1 month ago

Bug description

In the real time compressor and limiter it would be less confusing if the accessibility names of the sliders were just the names of the properties, rather than also including the units, eg, just Threshold, Knee width, etc. For these sliders, screen readers read a percentage value between 0 and 100. If units are included in the accessibility name, eg db, then the user may mistakenly assume that the percentage value is the value in db.

Compare this with, for example, Audacity's Bass and Treble effect, where the accessibility names of the sliders are just the names of the properties.

Steps to reproduce

With a screen reader running:

  1. Select some audio.
  2. On the effects menu, open either Audacity's limiter or compressor.
  3. Tab to the slider for knee width.

Expected behavior

The name of the slider read by the screen reader is "knee width".

Actual behavior

The name of the slider read by the screen reader is "knee width (db)"

Audacity Version

current master / alpha / nightly build

Operating system

Windows

Additional context

No response

LWinterberg commented 1 month ago

Does this only apply to the limiter and compressor? I'm asking because the name/unit/textinput/slider combo is something that's pretty common in Audacity - including the old limiter.

image

It's also a thing in Noise Reduction, Tremolo, Delay, Distortion and probably more.

DavidBailes commented 1 month ago

Does this only apply to the limiter and compressor? I'm asking because the name/unit/textinput/slider combo is something that's pretty common in Audacity - including the old limiter.

No, some existing effects have this issue, but others don't. For example, in the Distortion effect, then the issue exists for the clipping level, whilst for the Noise reduction effect, the noise reduction parameter doesn't have this issue. For all nyquist effects (like the old limiter), the sliders have no names, since there is currently no way of setting custom accessibility names in this case.