search

audeering / audbcards

Data cards for audio datasets
https://audeering.github.io/audbcards/
Other
0 stars 0 forks source link

Use ruff formatter as pre-commit #50

Closed hagenw closed 4 months ago

hagenw commented 5 months ago

As ruff now supports formatting of code like black, we extend pre-commit to also format the code using ruff.

hagenw commented 4 months ago

The authors section in pyproject.toml misspells my name. As this hasn't been touched in this MR, I cannot suggest an edit.

I would propose to fix this in another pull request. Please also check the license file.

hagenw commented 4 months ago

What audeering packages should be contained [tool.ruff.isort.sections] . All packages from the https://github.com/audeering/ are so far included. If this is desired then this is ok. If only all dependencies are needed then the section contains too many packages right now.

There is no clear rule at the moment. I think for the open-source ones, I included all open-source packages, excluding the actual package (this is unfortunately also the reason why we cannot use the same entries in all projects).

ChristianGeng commented 4 months ago

The authors section in pyproject.toml misspells my name. As this hasn't been touched in this MR, I cannot suggest an edit.

I would propose to fix this in another pull request. Please also check the license file.

Ok then I would see this thread as resolved. The license file does not misspell my surname.

ChristianGeng commented 4 months ago

What audeering packages should be contained [tool.ruff.isort.sections] . All packages from the https://github.com/audeering/ are so far included. If this is desired then this is ok. If only all dependencies are needed then the section contains too many packages right now.

There is no clear rule at the moment. I think for the open-source ones, I included all open-source packages, excluding the actual package (this is unfortunately also the reason why we cannot use the same entries in all projects).

Fair enough. I think all open source packages is a good solution. So this thread is also done.