search

audeering / audbcards

Data cards for audio datasets
https://audeering.github.io/audbcards/
Other
0 stars 0 forks source link

Fix typo in Python package author name #60

Closed ChristianGeng closed 7 months ago

ChristianGeng commented 7 months ago

Closes #57

ChristianGeng commented 7 months ago

There is a remaining asymmetry with (an) author(s) occurring in pyproject.toml but not in LICENSE. Also an email address is missing. An unrelated typo was fixed after performing spell checking.

hagenw commented 7 months ago

Also an email address is missing.

Where is the email address missing? I don't see any changes in this pull request regarding an email address.

hagenw commented 7 months ago

Ah, ok, you mean there is still one email address missing in pyproject.toml, which is not corrected in this pull request?

hagenw commented 7 months ago

If you are referring to {name = 'BahaEddine Abrougui'},, I just removed the email address as his old email address is no longer working, and he is no longer contributing at the moment. So it feels easier to maintain to me, to not add any email address in this case.

hagenw commented 7 months ago

Could you update the title of this pull request to something like: "Fix typo in Python package author name". I would say the other fix, we don't need to mention in the title.

ChristianGeng commented 7 months ago

Could you update the title of this pull request to something like: "Fix typo in Python package author name". I would say the other fix, we don't need to mention in the title.

DONE.

ChristianGeng commented 7 months ago

Could you update the title of this pull request to something like: "Fix typo in Python package author name". I would say the other fix, we don't need to mention in the title.

DONE.

ChristianGeng commented 7 months ago

Ah, ok, you mean there is still one email address missing in pyproject.toml, which is not corrected in this pull request?

Yes exactly. You have answered this already though.