Closed hagenw closed 7 months ago
There is a slight downside of moving the print
statement to audbcards/sphinx/__init__.py
as we then no longer have a single value of truth for the name under which the file is stored. One way around might be that we add a return value to audbcards.Datacard.save()
, but I'm not sure if this is really necessary.
Another solution might be, to add a file
argument to audbcards.Datacard.save()
. Then we can define the filename directly inside audbcards/sphinx/__init__.py
as single source of truth, and also a user of the API would have the opportunity to store the RST at a custom path.
I updated the code and the title and description of this pull request by adding a file
argument to audbcards.Datacard.save()
.
I updated the code and the title and description of this pull request by adding a
file
argument toaudbcards.Datacard.save()
.
Looks good. For me this is ready to be merged.
This adds the
file
argument toaudbcards.Datacard.save()
to provide the user with more choice how to store a datacard.It also allows us to move all the stdout print messages when running the sphinx extension to
audbcards/sphinx/__init__.py
.It also changes the stdout from
to