Closed hagenw closed 5 months ago
The error you see with Python 3.12 is related to caused by https://github.com/devopshq/artifactory/issues/430. Until that is solved all our packages using Artifactory backends are blocked for Python 3.12.
For audbackend
2.0.0, I prepared already https://github.com/audeering/audbcards/pull/90, but I wanted to first get this here merged, so I can rebase my changes for audbbackend
2.0.0, before assigning it for review.
For me everything is addressed. I do not know how to later approve in github. I would if I did though. Anyway I am happy now and this can imo be merged.
Thanks. I also don't know how to later approve. I guess it is implicitly assumed that it is approved when all discussions are resolved. Otherwise, I would have to re-request a review, and then you could approve.
Add caching for results (e.g. PNG files) generated by
audbcards.Datacard
.To achieve this, I did the following:
audbcards.Datacard.example_media
toaudbcards.Dataset.example_media
as it requires access to the dependency table (audbcards.Dataset.deps
), and hence it is better suited to be cached as part ofaudbcards.Dataset
.cache_root
argument toaudbcards.Datacard
. It uses per default the same folder asaudbcards.Dataset
.audbcards.Datacard.file_duration_distribution()
in the cache folder.audbcards.Datacard.player()
in the cache folder.The structure of the stored cache files is (shown by the example for
emodb
):I again tested building the pages for all our datasets and now get:
whereas now most of the time is spend on compiling the HTML pages, and not on gathering information about the datasets.
Updated docstrings: