search

audeering / audeer

Helpful Python functions
https://audeering.github.io/audeer/
Other
3 stars 0 forks source link

Not follow symlinks in Ensure basename_wo_ext() #139

Closed hagenw closed 8 months ago

hagenw commented 8 months ago

Relates to #136

The result of audeer.basename_wo_ext() should not be influenced by existing files or symlinks.

This adds first a failing test for the current behavior and then a fix, that avoids following symlinks.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc375de) 100.0% compared to head (6e4fc73) 100.0%.

Additional details and impacted files | [Files](https://app.codecov.io/gh/audeering/audeer/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=audeering) | Coverage Δ | | |---|---|---| | [audeer/core/io.py](https://app.codecov.io/gh/audeering/audeer/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=audeering#diff-YXVkZWVyL2NvcmUvaW8ucHk=) | `100.0% <100.0%> (ø)` | |
hagenw commented 8 months ago

This is now longer needed as this is the new default, see https://github.com/audeering/audeer/pull/140