Closed frankenjoe closed 3 years ago
It's not directly malformed, but it might be that some programs cannot work with it.
I agree, that we should change it.
The same happens for name
, repo
.
For version
it would add an /
at the end, which would not happen otherwise.
On the other hand you could also argue that it is a feature not a bug that group_id=''
returns something different than group_id=None
.
I encountered the problem in audbackend
at this line:
https://github.com/audeering/audbackend/blob/master/audbackend/core/artifactory.py#L41
when audfactory.path_to_group_id(folder)
returns ''
if folder
is empty. So if we don't fix this here, we have to fix it in audbackend
. But maybe we do similar things in other projects, so to me it feels safer to fix it here. Unless there is a use-case where we want to create an URL that has //
in the path. But I doubt there is one. At least with Artifactory
it will not find the artifact in that case.
OK, as Artifactory cannot cope with it, I would say we should fix it here.
With
group_id=''
we get a malformed URL:I guess it's better if we ignore
group_id
in that case.