audeering / audfactory

Communicating with Artifactory

https://audeering.github.io/audfactory/

Other

0 stars 0 forks source link

FIX: ignore empty string arguments in url() #26

Closed frankenjoe closed 3 years ago

frankenjoe commented 3 years ago

Closes #25

Example

audfactory.url(
    'https://host',
    group_id='',
    name='name',
    repository='repo',
    version='1.0.0',
)

https://host/repo/name/1.0.0

audfactory.url(
    'https://host',
    group_id='',
    name='',
    repository='repo',
    version='',
)

https://host/repo

audfactory.url(
    'https://host',
    repository='',
)

https://host

hagenw commented 3 years ago

As stated in #25 not only group_id is affected, but also the other arguments like name. Would you like to fix it here as well, or in a separate pull request?

codecov[bot] commented 3 years ago

Codecov Report

Merging #26 (f6d8188) into master (07bfd02) will not change coverage. The diff coverage is 100.0%.

Impacted Files	Coverage Δ
audfactory/core/api.py	`100.0% <100.0%> (ø)`

frankenjoe commented 3 years ago

As stated in #25 not only group_id is affected, but also the other arguments like name. Would you like to fix it here as well, or in a separate pull request?

I guess it makes sense to fix this here as well and change the name / description of the PR accordingly.

frankenjoe commented 3 years ago

I guess it makes sense to fix this here as well and change the name / description of the PR accordingly.

done