search

audeering / audfactory

Communicating with Artifactory
https://audeering.github.io/audfactory/
Other
0 stars 0 forks source link

audfactory.Lookup operations take too long #5

Open hagenw opened 3 years ago

hagenw commented 3 years ago

To see the issue just execute the tests:

$ python -m pytest tests/test_lookup.py

As this operation is called a lot when handling benchmarks and models it seems important to me to improve on this.

hagenw commented 3 years ago

Those tests seem to run even slower on MacOS and can also fail there from time to time, see https://github.com/audeering/audfactory/issues/8

hagenw commented 2 years ago

As proposed in https://github.com/audeering/audfactory/issues/8#issuecomment-982809266 we should consider to deprecate and remove audfactory.Lookup as we are no longer using it and there is no need to maintain it any longer.

frankenjoe commented 2 years ago

as we are no longer using it

Thinking about it - audfeatures might still use it. Though I guess we should also remove it from there like we did with audmodel.

hagenw commented 2 years ago

audfactory.Lookup is still part of the API, see https://audeering.github.io/audfactory/api-audfactory.html#lookup. I'm wondering if we should mark it as deprecated and remove it in version 2.0.0, or if we should simply stay with it, but don't spend effort and try to make it faster?

frankenjoe commented 2 years ago

What about audfeatures, isn't it still using it?

frankenjoe commented 2 years ago

Otherwise, I'd suggest to mark it deprecated and remove it as it is also not supported by other backends.

hagenw commented 2 years ago

What about audfeatures, isn't it still using it?

I doubt that audfeatures is still in a working condition, but yes we are still using it there.

But I think marking it as deprecated will not be a big problem as it will be removed anyway only in version 2.0.0. But the good think is that when it is marked as deprecated we don't have to work on it and improve it.

frankenjoe commented 2 years ago

Ok, then go ahead and mark it deprecated!