Closed hagenw closed 3 years ago
Unfortunately, I cound't figure out how get a user name and password for https://audeering.jfrog.io/artifactory, so I couldn't really test any code. But I have built the documentation and I think it looks good! I only have few comments:
Why audfactory.server_url()
and not just audfactory.url()
?
Maybe use :mod
audfactory` here:
is_semantic_version()
is not working:The good news is you accessed https://audeering.jfrog.io/artifactory already. Building the documentation is accessing the data-public
repository which has anonymous access.
For the other one you need to add an additional entry to ~/.artifactory_python.cfg
and I will create a user account for you.
Not sure yet where we document this.
I renamed audfactory.server_url()
to audfactory.url()
and took the opportunity to do the same with audfactory.artifactory_path()
, audfactory.deploy_artifact()
and audfactory.download_artifact()
.
I didn't use :mod:
in the README as the README should also look nice on Github.
I fixed the link to audeer.is_semantic_version()
The current master is the release candidate for version
1.0.0
ofaudfactory
. Would be nice to check if you agree with the currently proposed API. To check you need to compile the documentation locally.Here is a summary of all the changes compared to version 0.8.1:
audfactory.config.ARTIFACTORY_ROOT
and add support for different Artifactory server locationsaudfactory/core/api.py
on the https://audeering.jfrog.io/artifactory serveraudfactory/core/lookup.py
as we don't have public lookup tables at the moment (and I think it is not worth the effort to include that already in the 1.0.0 release)group_id
,name
,version
,repository
as arguments I added anotherserver
argument where you now have to specify the URL of your Artifactory server