search

audeering / audtorch

Utils and data sets for audio and PyTorch
https://audeering.github.io/audtorch/
Other
83 stars 9 forks source link

Remove scipy from code? #66

Open hagenw opened 4 years ago

hagenw commented 4 years ago

With not including librosa in the dependencies we had the problem of #50. In the end, we added it to setup.cfg.

We still have a hidden dependency on scipy, which is not listed in setup.cfg, and I'm reluctant to add it there. It is used as a non-default option in transforms.Resample. My question is: should we just stay with it, or maybe remove the scipy resample option altogether as it can crash as well?

ATriantafyllopoulos commented 4 years ago

If I remember correctly this was the fastest options for small files, right?

hagenw commented 4 years ago

Yes, it was. But at the moment the recommended workflow is to do the resampling first anyway.